Fix vale errors #56
Open
Fix vale errors #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red Hat documentation is usually linted using vale. Fixing error level reported issues. Ignored for now warnings and suggestions, can be handled in follow up patches. See also: https://github.com/redhat-documentation/vale-at-red-hat Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
|
Thanks for the PR, @sandrobonazzola! Do you happen to know if Red Hat provides a shared package for the RH-specific Vale vocabulary? (Ref: https://vale.sh/docs/keys/packages) It seems a bit redundant for each repository to maintain its own copy of the vocabulary. A central package would help reduce duplication and ensure consistency. |
|
Removed the local copy, I see it can be fetched from vale tool itself and within the pre-commit hook as well. |
Red Hat package is available in the official [Package Explorer](https://vale.sh/explorer) and pre-commit hook can fetch it automatically. In order to fetch it manually, just call `vale sync`. Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
sandrobonazzola
force-pushed
the
fix-vale-errors
branch
from
fb4b8fb to
9e29da0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Red Hat documentation is usually linted using vale. Fixing error level reported issues.
Ignored for now warnings and suggestions, can be handled in follow up patches.
See also: https://github.com/redhat-documentation/vale-at-red-hat