Skip to content

Conversation

tdawson
Copy link
Member

@tdawson tdawson commented Aug 13, 2025

Parallelize the dependency gathering when we download and processing a root log.
This was AI Assisted.

@tdawson
Copy link
Member Author

tdawson commented Aug 13, 2025

I have tested this enough to know that it does the parallelization, and that the command line option works.
I have not done a full test run to see the time difference between a parallelization of 1 vs the default of 10.
I don't recommend merging this until a full test run has been done.

Copy link
Member

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits 4 and 7 should be squashed into 1. That shouldn't invalidate testing since we're only testing the final result of the PR, which will be identical. Besides that, once change below.

@tdawson tdawson force-pushed the parallel-root-log branch from 892c23e to 4a978a8 Compare August 15, 2025 13:51
@tdawson
Copy link
Member Author

tdawson commented Aug 15, 2025

I have squashed the relevant changes. (7 into 4) (8 into 6).

@tdawson
Copy link
Member Author

tdawson commented Aug 15, 2025

Github really has a hard time when "Change requests" are requested. There is no way to indicate that it's done.

@yselkowitz
Copy link
Member

Github really has a hard time when "Change requests" are requested. There is no way to indicate that it's done.

You can re-request review by clicking the circular arrows next to the reviewer.

Copy link
Member

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once your tests have completed and you're satisfied with the results, please go ahead and merge.

@tdawson
Copy link
Member Author

tdawson commented Aug 15, 2025

It has passed all my tests. Merging it.

@tdawson tdawson merged commit 702f06f into fedora-eln:master Aug 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content Resolver: parallelize root log

2 participants