-
Notifications
You must be signed in to change notification settings - Fork 27
Parallelize root log #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have tested this enough to know that it does the parallelization, and that the command line option works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits 4 and 7 should be squashed into 1. That shouldn't invalidate testing since we're only testing the final result of the PR, which will be identical. Besides that, once change below.
892c23e
to
4a978a8
Compare
I have squashed the relevant changes. (7 into 4) (8 into 6). |
Github really has a hard time when "Change requests" are requested. There is no way to indicate that it's done. |
You can re-request review by clicking the circular arrows next to the reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once your tests have completed and you're satisfied with the results, please go ahead and merge.
It has passed all my tests. Merging it. |
Parallelize the dependency gathering when we download and processing a root log.
This was AI Assisted.