Skip to content

Conversation

@jamesmblair
Copy link
Collaborator

No description provided.

@jamesmblair jamesmblair added the notes:ignore Ignore for release notes label Feb 5, 2025
@jamesmblair jamesmblair added this to the 1.0.0 milestone Feb 5, 2025
@jamesmblair jamesmblair self-assigned this Feb 5, 2025
This was linked to issues Feb 5, 2025
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

Test Results

102 tests  +30   100 ✅ +28   0s ⏱️ ±0s
  1 suites ± 0     2 💤 + 2 
  1 files   ± 0     0 ❌ ± 0 

Results for commit ad29456. ± Comparison against base commit 41cf182.

♻️ This comment has been updated with latest results.

@jamesmblair jamesmblair linked an issue Feb 5, 2025 that may be closed by this pull request
@paulirwin
Copy link
Member

Also, we should probably not run the publish/nuget actions on PRs.

@github-actions
Copy link

github-actions bot commented Feb 6, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
F23.Kernel 90% 81% 125
F23.Kernel.AspNetCore 97% 97% 73
Summary 92% (243 / 264) 91% (109 / 120) 198

@jamesmblair jamesmblair marked this pull request as ready for review February 6, 2025 16:18
@jamesmblair
Copy link
Collaborator Author

Regarding the NuGet action, see line 64 in .github/workflows/publish.yml. It only pushes to NuGet if the trigger is a GitHub release. Otherwise, it's just running dotnet pack to validate the successful creation of a package.

@jamesmblair jamesmblair self-assigned this Feb 22, 2025
@jamesmblair
Copy link
Collaborator Author

@paulirwin See my comment above. Can I get this merged?

@paulirwin paulirwin merged commit 8953c4e into main Feb 24, 2025
7 checks passed
@paulirwin paulirwin deleted the feature/tests-and-release branch February 24, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:ignore Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup NuGet Publish to run upon GitHub release creation Document C# Public APIs Write Project README

3 participants