Fix crash in GiveReadableTensorNames #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases,
GiveReadableTensorNamescan crash due to a collision of two tensors with the same randomly generated name. This is the case, becausemodel.rename_tensorassumes that each tensor name in the graph is unique. If two tensors get assigned the same random name byGiveRandomTensorNamesthis condition is violated and the code crashes.In this PR I fixed the problem by introducing the
GiveUniqueTensorNamestransformation, which just numbers all tensors. As a result, the naming is unique and can be used inGiveReadableTensorNames.(Additionally, just iterating all tensors in a graph and assigning numbers is also a bit faster than randomly generating strings for names.)