Skip to content

[DataType] vectorize checking if value is allowed for a datatype #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SpiritSeeker
Copy link
Collaborator

@SpiritSeeker SpiritSeeker commented Jun 20, 2025

  • vectorized implementation of value checking for all QONNX datatypes
  • added value checking test cases with multi-dimensional numpy arrays
  • use vectorized value checking in sanitize_quant_values
  • TODO: check for any other internal value checks which might need to be replaced with the vectorized versions.

@maltanar
Copy link
Collaborator

thanks @SpiritSeeker - the PR itself looks good, but while we have the topic open please do add the incorporation into sanitize_quant_values.

@maltanar maltanar merged commit 2a2065e into fastmachinelearning:main Jun 27, 2025
3 checks passed
@SpiritSeeker SpiritSeeker deleted the vectorize-datatype-allowed branch June 27, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants