Skip to content

Treat PReLU in infer_precision #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JanFSchulte
Copy link
Contributor

@JanFSchulte JanFSchulte commented Jul 14, 2025

Fixes #1328 by making sure the precision of the PReLU parameters is correctly inferred. Not inferring them prevented them to be written into the firmware files.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change that fixes an issue)

Tests

Script provided in the issue passes after applying this fix.

Test Configuration:

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar
Copy link
Contributor

vloncar commented Jul 14, 2025

You don't want to enable that disabled test in pytests?

@JanFSchulte
Copy link
Contributor Author

Was still trying to get that one to work again. There is still an issue with 3-dim inputs where our results don't look ok, but that's out of scope for thins PR I think.

@JanFSchulte JanFSchulte added the please test Trigger testing by creating local PR branch label Jul 14, 2025
@JanFSchulte JanFSchulte added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PReLU parameters not generated
2 participants