Skip to content

Pooling Template Fix and HGQ2 QPooling Layer Support #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

calad0i
Copy link
Contributor

@calad0i calad0i commented Jul 6, 2025

Description

(This PR includes #1321)

  • Fixes pooling layers in io parallel implementation when strides are non-trivial (!= pool_size)
  • Fixes keras v3 parser padding computation
  • Added QPooling layer support for HGQ2

Known Issue

  • Pooling in io_stream with non-trivial strides could still crash, most likely when strides > pool_size.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)

Tests

Updated test_pooling.py; HGQ2 tests are added in the HGQ2 repo.
(keras v3 tests will not be triggered here anyway; in the future maybe we can directly reuse HGQ2's hls4ml convert tests)

Test Configuration:

Checklist

  • all, but no doc

@calad0i calad0i added the please test Trigger testing by creating local PR branch label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant