🦄 refactor: optimize log output #345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unified log output using the loguru logging library
wu-clan
reviewed
Jul 9, 2024
| # print(frame, depth) | ||
| # while frame and frame.f_code and frame.f_code.co_filename == logging.__file__: | ||
| # frame = frame.f_back | ||
| # depth += 1 |
There was a problem hiding this comment.
Please delete the comments and code here.
| # depth += 1 | ||
|
|
||
| # Find caller from where originated the logged message. | ||
| # 换成inspect获取 |
|
|
||
| # remove every other logger's handlers | ||
| # and propagate to root logger | ||
| # noinspection PyUnresolvedReferences |
There was a problem hiding this comment.
The comment here does not match the code
backend/core/registrar.py
Outdated
| :return: | ||
| """ | ||
| from backend.common.log import setup_logging, set_customize_logfile | ||
| setup_logging("INFO") |
There was a problem hiding this comment.
Add logging level configuration to core/conf.py
backend/main.py
Outdated
| config = uvicorn.Config(app=f'{Path(__file__).stem}:app', reload=True) | ||
| server = uvicorn.Server(config) | ||
| from backend.common.log import setup_logging | ||
| setup_logging("INFO") |
There was a problem hiding this comment.
Remove this function to globally use the registration configuration by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified log output using the loguru logging library