Skip to content

Conversation

tristangdwl
Copy link
Collaborator

Some friends recently requested that we add support for redundant kernel names e.g. 'cp' and 'cprime' to the .kern files, unifying the notation with the kernel constructors.

At the same time, I added 'all', 'trans_rep', 'trans_rep_prime', 'c2trans' to kernel constructors for helm2d, helmd2dquas, 'helm2diff'.

Added alternate names

  • 'all', 'trans_sys', 'tsys'
  • 'trans_rep', 'trep'
  • 'trans_rep_p', 'trep_p'
  • 'c2trans', 'c2t', 'c2tr' <- Should we add support for s2trans and d2trans at the same time?
  • 'stau', 'st'
  • 'cgrad', 'cg' (and same for s and d)

Also added a test that helm2d.kern etc.. interleave correctly, i.e. that 'all' is really [D,S; C', S']

@tristangdwl tristangdwl requested a review from mrachh July 22, 2025 20:01
Copy link
Member

@askhamwhat askhamwhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

@askhamwhat askhamwhat merged commit 6a46b90 into master Oct 1, 2025
1 check passed
@tristangdwl tristangdwl deleted the flexible_kern_names branch October 8, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants