Update shape of vector valued quasiperiodic kernels #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restoring arclengthder method
askhamwhat
approved these changes
Oct 1, 2025
|
@tristangdwl the merge conflict is because i brought in your flexible name changes first, so it doesn't know how to merge the case/if statements. the partial merge i got seemed a little messed up when it comes to shape and it's probably better if you handle it. can you pull from this branch (I added a basic commit) and then pull in from master and resolve the conflicts? |
|
@askhamwhat I completed the merge. I also updated the test to do multiple points and fixed a few more shaping bugs. Is there anything else? |
…thms/chunkie into quasi_periodic_shapes
|
looks good. thanks @tristangdwl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordered the vector valued quasiperiodic kernels so that the shape is (nkappa, opdim(1) nt, opdim(2) ns), which makes it easier to integrate in kappa.
Also enabled more general coefficients in the 'c2trans' Helmholtz kernel. This allows us to return [a u; b du/dn] and fits the format of the other transmission kernels.