Skip to content

Fix the timing of setting the editor value #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the timing of setting the editor value #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions admin/src/components/TOASTUI/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,17 @@ class TOIEditor extends React.Component {
this.handleToggle = this.handleToggle.bind(this);
}

Copy link

@shardiwal shardiwal Feb 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per React method componentWillReceiveProps are considered legacy and advised to avoid them in new code. And that name will continue to work until version 17 only.

@iapain What's your suggestion here ?

componentWillReceiveProps = (nextProps) => {
// It seems that Strapi sets the value property after the editor was initialized,
// this rendering initialValue useless, and proper value never making it into
// the component. Instead, we are setting the value manually, but only on the first
// update.
if (nextProps.value !== this.props.value && this.props.value == null) {
const editor = this.editorRef.current.getInstance();
editor.setMarkdown(nextProps.value, false);
}
}

componentDidMount() {
const editor = this.editorRef.current.getInstance();
const toolbar = editor.getUI().getToolbar();
Expand Down