-
Notifications
You must be signed in to change notification settings - Fork 4
eslint 9 migration with flat config #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@siuvdlec can we release an alpha version then? |
yep, 1.0.0-rc.0 |
fix: remove unnecessary replicated import of node recommended settings
|
Hi @thomasvargiu and @siuvdlec, One thing I noticed: when trying to use this setup in another project, I had to explicitly define all the ignore paths. With Do you think it makes sense to include these ignore paths directly in the plugin configuration? |
|
@giacomoforlani I'm not experiencing something like that. Probably you need to update the command with something like this |
|
Hey @thomasvargiu, I made a few tweaks to the ESLint config to make it work. Since ESLint 9 doesn’t support the Even though .js files aren’t included in the files pattern, ESLint still scans them unless you explicitly ignore them—so I added As for the I also added the --flag v10_config_lookup_from_file option. This changes how ESLint finds its config: instead of starting from the working directory, it starts from the file being linted and walks up the folder tree until it finds a config file. We need to report these adjustments in a migration guide. Other than that, the MR is ready for review, merge, and release by @siuvdlec. |
@smarttools/eslint-plugin-rxjsfor eslint 9 compatibilityResolves #10