Drop support for python 3.8 #3089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Jasha10
approved these changes
Oct 26, 2025
| select = E,F,W,C | ||
| copyright-regexp=Copyright \(c\) Facebook, Inc. and its affiliates. All Rights Reserved | ||
| ignore=W503,E203,E701,E704 | ||
| ignore=W503,E203,E231,E701,E704 |
There was a problem hiding this comment.
Out of curiosity, why is it necessary to ignore E231?
There was a problem hiding this comment.
I was hitting commit-blocking false positives on some literal string patterns. Black would already reformat any code that would have actually violated this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omegaconf 2.4.0 drops support for 3.8. Thus hydra will for its upcoming release
Only run lint once to not make failures noisy