Skip to content

Conversation

@jesszzzz
Copy link
Contributor

@jesszzzz jesszzzz commented Aug 12, 2025

Motivation

fb environment has some extra restrictions to build the website:

  • Some resolutions were referencing old dependencies that no longer apply so they have to be removed
  • It should not rely on having access to git history during the build

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

CI created preview site looks good https://deploy-preview-3079--hydra-preview.netlify.app/

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 12, 2025
@jesszzzz jesszzzz marked this pull request as ready for review August 12, 2025 19:46
Copy link

@andywag andywag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jesszzzz jesszzzz merged commit 12dde7d into main Aug 13, 2025
41 checks passed
@jesszzzz jesszzzz deleted the fix_yarn_build branch August 13, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants