Add check for struct sizes #4172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69243348 |
Summary: C++ Faiss is compiled with (at least) 3 compilers: - the one compiling the main CPU Faiss - the one called by nvcc to compile host code on GPU Faiss - the one compiling the SWIG generated file Sometimes the compilers are misconfigured and have different ideas of data alignment, size and packing. This is a hard to catch bug. This test attemtps to check if one of these differences occur. The test did catch the bug in one configuration in the Github version, see facebookresearch#4136 https://github.com/facebookresearch/faiss/actions/runs/13177278514/job/36779465009?pr=4136 Reviewed By: mnorris11 Differential Revision: D69243348
mdouze
force-pushed
the
export-D69243348
branch
from
264d6e5 to
3e318f0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69243348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
C++ Faiss is compiled with (at least) 3 compilers:
Sometimes the compilers are misconfigured and have different ideas of data alignment, size and packing. This is a hard to catch bug.
This test attemtps to check if one of these differences occur.
The test did catch the bug in one configuration in the Github version, see
#4136
https://github.com/facebookresearch/faiss/actions/runs/13177278514/job/36779465009?pr=4136
Differential Revision: D69243348