Fix bug in PCA balanced bins eigenvalues accumulator #4154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: PCA balanced bins should be product of eigenvalues not sum of eigenvalues Differential Revision: D68839548
|
This pull request was exported from Phabricator. Differential Revision: D68839548 |
pankajsingh88
added a commit
to pankajsingh88/faiss
that referenced
this pull request
Jan 30, 2025
…h#4154) Summary: PCA balanced bins should be product of eigenvalues not sum of eigenvalues Differential Revision: D68839548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: PCA balanced bins should be product of eigenvalues not sum of eigenvalues
Differential Revision: D68839548