Skip to content
This repository was archived by the owner on Apr 28, 2023. It is now read-only.

Fix maybe uninitialized variable warning triggering error appearing with TC_CHECK #500

Conversation

nicolasvasilache
Copy link
Contributor

For some reason they only triggered for me when trying to rebase tc_check.
This is still relevant as an independent fix.

For some reason they only triggered for me when trying to rebase tc_check.
This is still relevant as an independent fix.
@nicolasvasilache nicolasvasilache merged commit 02b7b05 into facebookresearch:master Jun 11, 2018
@ftynse
Copy link
Contributor

ftynse commented Jun 11, 2018

What was the exact error message? Was it an error or an escalated warning? This looks surprising that the variables were considered undefined. You seem to have only added the non-default initialization. I'd like to understand better what happened here...

@ftynse ftynse mentioned this pull request Jun 11, 2018
@nicolasvasilache
Copy link
Contributor Author

@ftynse see #504 (it should show in the CI)

@nicolasvasilache nicolasvasilache changed the title Fix undefined variable errors Fix maybe uninitialized variable warning triggering error appearing with TC_CHECK Jun 11, 2018
@nicolasvasilache
Copy link
Contributor Author

@ftynse reworded the PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants