Skip to content
This repository was archived by the owner on Apr 28, 2023. It is now read-only.

Tc check #460

Merged
merged 4 commits into from
Jun 11, 2018
Merged

Tc check #460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02b7b05
Fix undefined variable errors
nicolasvasilache Jun 11, 2018
dcbc4a7
Implement TC_CHECK(_*) macros
May 29, 2018
31a30ef
Replace all occurences of CHECK_* with TC_CHECK_*
Jun 11, 2018
3682a4f
Implement TC_CHECKs with custom exception types
Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tc/core/mapping_options-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ MappingOptionsView& MappingOptionsView::scheduleFusionStrategy(

MappingOptionsView& MappingOptionsView::scheduleFusionStrategy(
const std::string& str) {
FusionStrategy fs;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who complains about this and why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #500, I did not understand that either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #504 (it should show in the CI)

FusionStrategy fs(FusionStrategy::Max);
bool couldParse = FusionStrategy_Parse(str, &fs);
CHECK(couldParse) << "unknown FusionStrategy " << str;
return scheduleFusionStrategy(fs);
Expand All @@ -175,7 +175,7 @@ MappingOptionsView& MappingOptionsView::outerScheduleFusionStrategy(

MappingOptionsView& MappingOptionsView::outerScheduleFusionStrategy(
const std::string& str) {
FusionStrategy fs;
FusionStrategy fs(FusionStrategy::Max);
bool couldParse = FusionStrategy_Parse(str, &fs);
CHECK(couldParse) << "unknown FusionStrategy " << str;
return outerScheduleFusionStrategy(fs);
Expand All @@ -199,7 +199,7 @@ MappingOptionsView& MappingOptionsView::intraTileScheduleFusionStrategy(

MappingOptionsView& MappingOptionsView::intraTileScheduleFusionStrategy(
const std::string& str) {
FusionStrategy fs;
FusionStrategy fs(FusionStrategy::Max);
bool couldParse = FusionStrategy_Parse(str, &fs);
CHECK(couldParse) << "unknown FusionStrategy " << str;
return intraTileScheduleFusionStrategy(fs);
Expand Down
4 changes: 2 additions & 2 deletions test/isl_cli_strategy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ namespace tc {
// (at a minimum: tile, mapToThreads and mapToBlocks)
// 3. call makeCliStrategy with the overridden options
tc::CudaMappingOptions makeBaseCliStrategy() {
tc::FusionStrategy fs;
tc::FusionStrategy fs(FusionStrategy::Max);
CHECK(tc::FusionStrategy_Parse(DEFAULT_FUSION_STRATEGY, &fs));
CudaMappingOptions options =
CudaMappingOptions::makeNaiveMappingOptions()
Expand All @@ -104,7 +104,7 @@ tc::CudaMappingOptions makeBaseCliStrategy() {

tc::CudaMappingOptions makeCliStrategy(tc::CudaMappingOptions options) {
if (FLAGS_fusion_strategy != std::string(DEFAULT_FUSION_STRATEGY)) {
tc::FusionStrategy fs;
tc::FusionStrategy fs(FusionStrategy::Max);
if (tc::FusionStrategy_Parse(FLAGS_fusion_strategy, &fs)) {
options.scheduleFusionStrategy(fs);
} else {
Expand Down