Drop useless output vector from benchmark Check function

Author: nicolasvasilache

tc/benchmarks/MLP_model.cc

@@ -214,8 +214,7 @@ def _1LUT(float(E1, D) LUT1, int32(B, L1) I1) -> (O1) {
           inputs,
           check_fun);
     } else {
-      std::vector<at::Tensor> outputs;
-      Check(tc, "_1LUT", options, inputs, outputs, check_fun);
+      Check(tc, "_1LUT", options, inputs, check_fun);
       if (use_flags) {
         autotune(
             FLAGS_save_tuner_proto_prefix + std::string("/1LUT_cache") + suffix,
@@ -328,8 +327,7 @@ def _2LUT(float(E1, D) LUT1, int32(B, L1) I1, float(E2, D) LUT2, int32(B, L2) I2
           inputs,
           check_fun);
     } else {
-      std::vector<at::Tensor> outputs;
-      Check(tc, "_2LUT", options, inputs, outputs, check_fun);
+      Check(tc, "_2LUT", options, inputs, check_fun);
       if (use_flags) {
         autotune(
             FLAGS_save_tuner_proto_prefix + std::string("/2LUT_cache") + suffix,
@@ -382,8 +380,7 @@ def _C3(float(B,WX) I, float(WY, WX) W) -> (C3) {
         inputs,
         check_fun);
   } else {
-    std::vector<at::Tensor> outputs;
-    Check(tc, "_C3", options, inputs, outputs, check_fun);
+    Check(tc, "_C3", options, inputs, check_fun);
     if (use_flags) {
       autotune(
           FLAGS_save_tuner_proto_prefix + std::string("/_C3_cache") + suffix,
@@ -438,8 +435,7 @@ def mlp1(float(B,M) I, float(M, N) W1, float(N) B1) -> (O1) {
         inputs,
         check_fun);
   } else {
-    std::vector<at::Tensor> outputs;
-    Check(tc, "mlp1", options, inputs, outputs, check_fun);
+    Check(tc, "mlp1", options, inputs, check_fun);
     if (use_flags) {
       autotune(
           FLAGS_save_tuner_proto_prefix + std::string("/mlp1_cache") + suffix,
@@ -509,9 +505,7 @@ def mlp3(float(B,N) I, float(O,N) W2, float(O) B2, float(P,O) W3, float(P) B3, f
         inputs,
         check_fun);
   } else {
-    std::vector<at::Tensor> outputs;
-
-    Check(tc, "mlp3", options, inputs, outputs, check_fun);
+    Check(tc, "mlp3", options, inputs, check_fun);
     if (use_flags) {
       autotune(
           FLAGS_save_tuner_proto_prefix + std::string("/mlp3_cache") + suffix,

tc/benchmarks/batchmatmul.cc

@@ -94,8 +94,7 @@ def batch_matmul(float(B, N, M) X, float(B, M, K) Y) -> (Z) {
         inputs,
         check_fun);
   } else {
-    std::vector<at::Tensor> outputs;
-    Check(tc, "batch_matmul", options, inputs, outputs, check_fun);
+    Check(tc, "batch_matmul", options, inputs, check_fun);
     if (use_flags) {
       autotune(
           FLAGS_save_tuner_proto_prefix + std::string("/batchmatmul_cache") +

tc/benchmarks/benchmark_fixture.h

@@ -102,14 +102,14 @@ struct Benchmark : public ::testing::Test {
       const std::string& name,
       const tc::CudaMappingOptions& mappingOptions,
       const std::vector<at::Tensor>& inputs,
-      std::vector<at::Tensor>& outputs,
       CheckFunction check_fun = [](const std::vector<at::Tensor>& inputs,
-                                   std::vector<at::Tensor>& outputs) {
+                                   const std::vector<at::Tensor>& outputs) {
         return true;
       }) {
     auto pExecutor =
         tc::aten::compile<tc::CudaBackend>(tc, name, inputs, mappingOptions);
-    outputs = tc::aten::prepareOutputs(tc, name, inputs);
+    std::vector<at::Tensor> outputs =
+        tc::aten::prepareOutputs(tc, name, inputs);
     tc::aten::run(*pExecutor, inputs, outputs);
     EXPECT_TRUE(check_fun(inputs, outputs));
     for (size_t i = 1; i < tc::FLAGS_benchmark_warmup; ++i) {

tc/benchmarks/group_convolution.cc

@@ -146,8 +146,7 @@ def group_convolution(float(N,G,C,H,W) I, float(G,F,C,KH,KW) W1, float(G,F) B)
         inputs,
         check_fun);
   } else {
-    std::vector<at::Tensor> outputs;
-    Check(tc, "group_convolution", options, inputs, outputs, check_fun);
+    Check(tc, "group_convolution", options, inputs, check_fun);
     if (use_flags) {
       autotune(
           FLAGS_save_tuner_proto_prefix +

tc/benchmarks/tmm.cc

@@ -90,8 +90,7 @@ def tmm(float(M,K) A, float(N,K) B) -> (C) {
         inputs,
         check_fun);
   } else {
-    std::vector<at::Tensor> outputs;
-    Check(tc, "tmm", options, inputs, outputs, check_fun);
+    Check(tc, "tmm", options, inputs, check_fun);
     if (use_flags) {
       autotune(
           FLAGS_save_tuner_proto_prefix + std::string("/tmm_cache") + suffix,