Add support for DocModule returned in the items of ForzenModule

Summary:
# This diff stack
Separate the rules at https://buck2.build/docs/prelude/globals/ into separate pages. Each page will have it's own page. With such change it will be more clean and it will be faster  to open the page.

# This diff

This diff add support return `DocModule` for the items of FrozenModule in `.documentation`.

In later diffs, we would use `namespace` to get the documentation. It would return `DocModule`.
Without this change, we would not get the docs for inner of namespace

Reviewed By: JakobDegen

Differential Revision: D73931900

fbshipit-source-id: 6f54cf7b489b0e870a088eabe0ff663c6d838057

Author: Nero5023

starlark/src/docs.rs

@@ -39,7 +39,6 @@ use crate::eval::runtime::params::display::iter_fmt_param_spec;
 use crate::typing::Ty;
 use crate::values::StarlarkValue;
 use crate::values::Trace;
-use crate::values::Value;
 use crate::values::type_repr::StarlarkTypeRepr;
 
 /// The documentation provided by a user for a specific module, object, function, etc.
@@ -206,20 +205,6 @@ pub enum DocMember {
     Function(DocFunction),
 }
 
-impl DocMember {
-    pub(crate) fn from_value(value: Value) -> Self {
-        // If we have a value which is a complex type, the right type to put in the docs is not the type
-        // it represents, but it's just a property we should point at
-        match value.documentation() {
-            DocItem::Member(x) => x,
-            _ => DocMember::Property(DocProperty {
-                docs: None,
-                typ: value.get_type_starlark_repr(),
-            }),
-        }
-    }
-}
-
 /// The documentation for a type
 ///
 /// This is distinct from a module since, well, types and modules are different things, but more

starlark/src/environment/modules.rs

@@ -36,6 +36,7 @@ use crate::collections::Hashed;
 use crate::docs::DocItem;
 use crate::docs::DocMember;
 use crate::docs::DocModule;
+use crate::docs::DocProperty;
 use crate::docs::DocString;
 use crate::docs::DocStringKind;
 use crate::environment::EnvironmentError;
@@ -242,10 +243,17 @@ impl FrozenModule {
             })
             // FIXME(JakobDegen): Throws out information
             .map(|(k, v)| {
-                (
-                    k.as_str().to_owned(),
-                    DocItem::Member(DocMember::from_value(v.to_value())),
-                )
+                let doc_item = match v.to_value().documentation() {
+                    doc_module @ DocItem::Module(_) => doc_module,
+                    member @ DocItem::Member(_) => member,
+                    // If we have a value which is a complex type, the right type to put in the docs is not the type
+                    // it represents, but it's just a property we should point at
+                    DocItem::Type(_) => DocItem::Member(DocMember::Property(DocProperty {
+                        docs: None,
+                        typ: v.to_value().get_type_starlark_repr(),
+                    })),
+                };
+                (k.as_str().to_owned(), doc_item)
             })
             .collect();