fix: a lot of instances of clippy::needless_lifetimes

Summary:
This doesn't get all of them because:
1. there are so many of them
2. the lint is pretty jank

Part of facebook/buck2#943

X-link: facebook/buck2#944

Reviewed By: JakobDegen

Differential Revision: D74271655

Pulled By: dtolnay

fbshipit-source-id: c7e41c47248d4be1f5d33a14b676ab35fc5180e2

Author: lf-

allocative/allocative/src/flamegraph.rs

@@ -137,7 +137,7 @@ struct TreeRef<'a> {
     tree_id: TreeId,
 }
 
-impl<'a> TreeRef<'a> {
+impl TreeRef<'_> {
     fn write_flame_graph(&self, stack: &[&str], warnings: &mut String) -> FlameGraph {
         let mut flame_graph = FlameGraph::default();
         let tree = &self.trees[self.tree_id];
@@ -240,7 +240,7 @@ struct TreeStackRef<'t, 's> {
     stack: &'s mut TreeStack,
 }
 
-impl<'t, 's> TreeStackRef<'t, 's> {
+impl<'t> TreeStackRef<'t, '_> {
     fn current_data(&'t mut self) -> &'t mut TreeData {
         &mut self.trees[self.stack.tree]
     }

allocative/allocative/src/visitor.rs

@@ -61,7 +61,7 @@ pub struct Visitor<'a> {
     pub(crate) node_kind: NodeKind,
 }
 
-impl<'a> Drop for Visitor<'a> {
+impl Drop for Visitor<'_> {
     fn drop(&mut self) {
         self.exit_impl();
     }

gazebo/cmp_any/src/ord.rs

@@ -51,7 +51,7 @@ impl<'a> PartialEq for OrdAny<'a> {
     }
 }
 
-impl<'a> Eq for OrdAny<'a> {}
+impl Eq for OrdAny<'_> {}
 
 impl<'a> PartialOrd for OrdAny<'a> {
     #[inline]
@@ -61,7 +61,7 @@ impl<'a> PartialOrd for OrdAny<'a> {
 }
 
 /// Compare by type id first, then by value.
-impl<'a> Ord for OrdAny<'a> {
+impl Ord for OrdAny<'_> {
     #[inline]
     fn cmp(&self, other: &Self) -> Ordering {
         let type_cmp = self.type_id.cmp(&other.type_id);

gazebo/display_container/src/lib.rs

@@ -97,7 +97,7 @@ pub fn display_pair<'a, K: Display + 'a, V: Display + 'a>(
 
 struct DisplayPair<'a, K: Display, V: Display>(pub K, pub &'a str, pub V);
 
-impl<'a, K: Display, V: Display> Display for DisplayPair<'a, K, V> {
+impl<K: Display, V: Display> Display for DisplayPair<'_, K, V> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         Display::fmt(&self.0, f)?;
         f.write_str(self.1)?;
@@ -210,7 +210,7 @@ where
         suffix: &'a str,
         items: C,
     }
-    impl<'a, C> Display for Impl<'a, C>
+    impl<C> Display for Impl<'_, C>
     where
         C: Copy + IntoIterator,
         <C as IntoIterator>::Item: Display,

gazebo/dupe/src/option.rs

@@ -28,7 +28,7 @@ pub trait OptionDupedExt {
         Self::Item: Dupe;
 }
 
-impl<'a, T> OptionDupedExt for Option<&'a T> {
+impl<T> OptionDupedExt for Option<&T> {
     type Item = T;
 
     fn duped(self) -> Option<T>

gazebo/gazebo/src/cast.rs

@@ -45,7 +45,7 @@ pub unsafe fn ptr_mut<From, To>(x: &mut From) -> &mut To {
 }
 
 #[inline(always)]
-pub unsafe fn ptr_lifetime<'a, 'b, T: ?Sized>(x: &'a T) -> &'b T {
+pub unsafe fn ptr_lifetime<'b, T: ?Sized>(x: &T) -> &'b T {
     unsafe { &*(x as *const T) }
 }
 

starlark_derive/src/freeze.rs

@@ -35,7 +35,7 @@ struct Input<'a> {
     input: &'a DeriveInput,
 }
 
-impl<'a> Input<'a> {
+impl Input<'_> {
     fn angle_brankets(&self, tokens: &[TokenStream]) -> TokenStream {
         let span = self.input.span();
         if tokens.is_empty() {

starlark_derive/src/starlark_value.rs

@@ -433,7 +433,7 @@ impl ImplStarlarkValue {
             lifetime: &'a syn::Lifetime,
         }
 
-        impl<'a> syn::visit_mut::VisitMut for PatchTypesVisitor<'a> {
+        impl syn::visit_mut::VisitMut for PatchTypesVisitor<'_> {
             fn visit_type_mut(&mut self, i: &mut syn::Type) {
                 let lifetime = self.lifetime;
                 *i = syn::parse_quote_spanned! { i.span() =>

starlark_derive/src/util.rs

@@ -34,7 +34,7 @@ pub(crate) struct FieldsUtil<'a> {
     pub(crate) fields: &'a Fields,
 }
 
-impl<'a> Deref for FieldsUtil<'a> {
+impl Deref for FieldsUtil<'_> {
     type Target = Fields;
 
     fn deref(&self) -> &Self::Target {
@@ -75,7 +75,7 @@ pub(crate) struct DataStructUtil<'a> {
     pub(crate) data: &'a DataStruct,
 }
 
-impl<'a> Deref for DataStructUtil<'a> {
+impl Deref for DataStructUtil<'_> {
     type Target = DataStruct;
 
     fn deref(&self) -> &Self::Target {
@@ -171,7 +171,7 @@ pub(crate) struct VariantUtil<'a> {
     pub(crate) enum_util: DataEnumUtil<'a>,
 }
 
-impl<'a> Deref for VariantUtil<'a> {
+impl Deref for VariantUtil<'_> {
     type Target = syn::Variant;
 
     fn deref(&self) -> &Self::Target {
@@ -244,7 +244,7 @@ pub(crate) struct DataEnumUtil<'a> {
     pub(crate) data: &'a DataEnum,
 }
 
-impl<'a> Deref for DataEnumUtil<'a> {
+impl Deref for DataEnumUtil<'_> {
     type Target = DataEnum;
 
     fn deref(&self) -> &Self::Target {
@@ -289,7 +289,7 @@ pub(crate) enum StructOrEnumVariant<'a> {
     EnumVariant(VariantUtil<'a>),
 }
 
-impl<'a> StructOrEnumVariant<'a> {
+impl StructOrEnumVariant<'_> {
     pub(crate) fn span(self) -> Span {
         match self {
             StructOrEnumVariant::Struct(data) => data.span(),
@@ -311,7 +311,7 @@ pub(crate) enum DeriveInputUtil<'a> {
     Enum(DataEnumUtil<'a>),
 }
 
-impl<'a> Deref for DeriveInputUtil<'a> {
+impl Deref for DeriveInputUtil<'_> {
     type Target = DeriveInput;
 
     fn deref(&self) -> &Self::Target {
@@ -445,7 +445,7 @@ impl<'a> GenericsUtil<'a> {
     }
 }
 
-impl<'a> Deref for GenericsUtil<'a> {
+impl Deref for GenericsUtil<'_> {
     type Target = syn::Generics;
 
     fn deref(&self) -> &Self::Target {

starlark_lsp/src/definition.rs

@@ -275,7 +275,7 @@ impl LspModule {
 
     /// Look at the given scope and child scopes to try to find where the identifier
     /// accessed at Pos is defined.
-    fn find_definition_in_scope<'a>(scope: &'a Scope, pos: Pos) -> TempDefinition<'a> {
+    fn find_definition_in_scope(scope: &Scope, pos: Pos) -> TempDefinition<'_> {
         /// Look for a name in the given scope, with a given source, and return the right
         /// type of [`TempIdentifierDefinition`] based on whether / how the variable is bound.
         fn resolve_get_in_scope<'a>(