OSS edenfs_linux build fixes #1101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…brary dependencies Summary: Fixes integration test failure due to lack of a functioning python-psutil (on Linux, this requires the inclusion of native code which is not permitted in a zipapp). Test Plan: Run the following: ``` act --container-architecture linux/x86_64 -W ".github/workflows/edenfs_linux.yml" ``` Before this change, integration tests fail with a failure to initialize python-psutil. After this change, integraion tests run cleanly
Summary: Fixes integration test failure due to lack of a functioning python-psutil (on Linux, this requires the inclusion of native code which is not permitted in a zipapp). Test Plan: Run the following: ``` act --container-architecture linux/x86_64 -W ".github/workflows/edenfs_linux.yml" ``` Before this change, integration tests fail with a failure to initialize python-psutil. After this change, integraion tests run cleanly
Summary: Test Plan:
Summary: Test Plan:
Summary: Test Plan:
Summary: TakeoverData is failing to compile in the OSS build Test Plan: Confirm the following gets past the compilation step of TakeoverData.cpp ``` act --container-architecture linux/x86_64 -W ".github/workflows/edenfs_linux.yml" ```
Summary: Test Plan:
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D77674652. (Because this pull request was imported automatically, there will not be any future comments.) |
|
@ben-- Could you help rebasing this change? I made some changes to satisfy the linters and got some conflicts rebasing this diff - It'd be easier if ShipIt can import a stack as a stack instead of one commit... unfortunately we don't have the right tooling right now. We use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should be landed after or instead of #1100 (it includes that as the first commit)
This PR fixes a number of build issues in the OSS build. Each individual fix can be verified by running:
on the prior commit. (Though, due to job prioritization, sometimes you may find a different issue first.)
The above build still does not complete due to a lack of thrift file generation, but that modification will be largely independent of this "stack".