Support minimumFontScale in paragraphAttributes

[anupriya13]

Summary:

Support minimumFontScale in paragraphAttributes

Resolves #50934

Changelog:

Support minimumFontScale in paragraphAttributes

Test Plan:

Tested via this code here: microsoft/react-native-windows#14617

Before:

After:

minFontScale.mp4

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[NickGerleman]

Looks like we're missing the code to read from Props into this, or to incorporate it into the math used for adjustsFontSizeToFit? Having a field there, but never correctly populated, or used for its documented purpose, is confusing for future readers.

Can we add the other code around this?

[anupriya13]

Looks like we're missing the code to read from Props into this, or to incorporate it into the math used for adjustsFontSizeToFit? Having a field there, but never correctly populated, or used for its documented purpose, is confusing for future readers.

Can we add the other code around this?

We are using both adjustsFontSizeToFit and minimumFontScale in React Native Windows.

Refer

• https://github.com/microsoft/react-native-windows/blob/main/vnext/Microsoft.ReactNative/Fabric/platform/react/renderer/textlayoutmanager/TextLayoutManager.cpp

• [Fabric] Implement minimumFontScale in Text microsoft/react-native-windows#14617

• Implement adjustsFontSizeToFit property for Text in Fabric microsoft/react-native-windows#14519

minimumFontScale prop doesn't populates in updateProps for windows hence this change.

Could you please clarify which file/code you meant the gap about?

[NickGerleman]

Some props code in

react-native/packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h

Line 951 in 319ba0a

paragraphAttributes.minimumFontSize = convertRawProp(

others in ParagraphProps

then I would expect it to be used in the paragraph component view on iOS. Can probably find that by a quick search.

[anupriya13]

@NickGerleman I have updated it and also tested with RNW. Please refer before and after screenshots.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @anupriya13 in f53d066

^{When will my fix make it into a release? | How to file a pick request?}

[facebook-github-bot]

@cipolleschi merged this pull request in f53d066.