Skip to content

Remove unused com.facebook.react.bridge.MemoryPressure class #50924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mateoguzmana
Copy link
Collaborator

@mateoguzmana mateoguzmana commented Apr 24, 2025

Summary:

This class can be internalized as part of the initiative to reduce the public API surface. I've checked there are no relevant OSS usages.

Edit: we can remove it as has no usages

Changelog:

[INTERNAL] - Remove unused com.facebook.react.bridge.MemoryPressure class

Test Plan:

yarn test-android
yarn android

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2025
@mateoguzmana mateoguzmana marked this pull request as ready for review April 24, 2025 22:12
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 24, 2025
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@javache
Copy link
Member

javache commented Apr 25, 2025

I can't find any references at all to this enum, as MemoryPressureListener doesn't use it. Can you delete this instead?

@mateoguzmana
Copy link
Collaborator Author

I can't find any references at all to this enum, as MemoryPressureListener doesn't use it. Can you delete this instead?

Oh, good catch, thanks. I've removed it now

@mateoguzmana mateoguzmana changed the title Make MemoryPressure internal Remove unused com.facebook.react.bridge.MemoryPressure class Apr 25, 2025
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 28, 2025
@facebook-github-bot
Copy link
Contributor

@rshest merged this pull request in 29cc235.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mateoguzmana in 29cc235

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants