a11y] Let links discovered by dataDetectorType be accessible #50914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73612119 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Apr 24, 2025
…k#50914) Summary: The URL spans generated by Linkify are not actually accessible because we do not update the delegate's virtual views. I also had to change how AccessibilityLinks get generated, since it does not work well if it includes spans that are not `ReactClickableSpans` Differential Revision: D73612119
joevilches
force-pushed
the
export-D73612119
branch
from
d41b2bb to
74909c4
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Apr 24, 2025
…k#50914) Summary: The URL spans generated by Linkify are not actually accessible because we do not update the delegate's virtual views. I also had to change how AccessibilityLinks get generated, since it does not work well if it includes spans that are not `ReactClickableSpans` Differential Revision: D73612119
joevilches
force-pushed
the
export-D73612119
branch
from
74909c4 to
da34c65
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73612119 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Apr 24, 2025
…k#50914) Summary: Pull Request resolved: facebook#50914 The URL spans generated by Linkify are not actually accessible because we do not update the delegate's virtual views. I also had to change how AccessibilityLinks get generated, since it does not work well if it includes spans that are not `ReactClickableSpans` Differential Revision: D73612119
joevilches
force-pushed
the
export-D73612119
branch
from
da34c65 to
d29f193
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73612119 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Apr 24, 2025
…k#50914) Summary: Pull Request resolved: facebook#50914 The URL spans generated by Linkify are not actually accessible because we do not update the delegate's virtual views. I also had to change how AccessibilityLinks get generated, since it does not work well if it includes spans that are not `ReactClickableSpans` Differential Revision: D73612119
joevilches
force-pushed
the
export-D73612119
branch
from
d29f193 to
92fceaa
Compare
…en dataDetector is present Differential Revision: D73549839
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Apr 24, 2025
…k#50914) Summary: The URL spans generated by Linkify are not actually accessible because we do not update the delegate's virtual views. I also had to change how AccessibilityLinks get generated, since it does not work well if it includes spans that are not `ReactClickableSpans` Differential Revision: D73612119
joevilches
force-pushed
the
export-D73612119
branch
from
92fceaa to
9dfbe73
Compare
…k#50914) Summary: Pull Request resolved: facebook#50914 The URL spans generated by Linkify are not actually accessible because we do not update the delegate's virtual views. I also had to change how AccessibilityLinks get generated, since it does not work well if it includes spans that are not `ReactClickableSpans` Differential Revision: D73612119
|
This pull request was exported from Phabricator. Differential Revision: D73612119 |
joevilches
force-pushed
the
export-D73612119
branch
from
9dfbe73 to
2763fee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The URL spans generated by Linkify are not actually accessible because we do not update the delegate's virtual views.
I also had to change how AccessibilityLinks get generated, since it does not work well if it includes spans that are not
ReactClickableSpansDifferential Revision: D73612119