Skip to content

Migrate ViewGroupManager to kotlin #50895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

riteshshukla04
Copy link
Contributor

@riteshshukla04 riteshshukla04 commented Apr 24, 2025

Summary:

This PR aims to migrate ViewGroupManager to kotlin as part of #50513

Changelog:

[ANDROID][CHANGED]Migrate ViewGroupManager to kotlin

Test Plan:

Tested with RN tester with old and new arch

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2025
@riteshshukla04
Copy link
Contributor Author

@mateoguzmana @cortinico @mdvacca Can you review this

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 24, 2025
@cortinico
Copy link
Contributor

@mateoguzmana are you doing a first pass?

@mateoguzmana mateoguzmana self-requested a review April 24, 2025 12:04
Copy link
Collaborator

@mateoguzmana mateoguzmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Noticed a few things

@riteshshukla04
Copy link
Contributor Author

@mateoguzmana Thanks for the review . I have resolved the comments . Can you re check

Copy link
Collaborator

@mateoguzmana mateoguzmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, the build seems failing as well, could you check that?

@riteshshukla04
Copy link
Contributor Author

One more thing, the build seems failing as well, could you check that?
@mateoguzmana
The build is broken due to some other PR . I think it will be fixed when below PR will be merged
#50905

@mateoguzmana mateoguzmana requested a review from cortinico April 24, 2025 20:29
@riteshshukla04
Copy link
Contributor Author

@cortinico Can you please review this?

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@riteshshukla04
Copy link
Contributor Author

riteshshukla04 commented Apr 29, 2025

@cortinico Can we merge this 😅

@cortinico
Copy link
Contributor

@cortinico Can we merge this 😅

Nope because this is breaking a bunch of things internally. I will have to look into this and change it so that the internal builds are not broken

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 29, 2025
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 761b158.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @riteshshukla04 in 761b158

When will my fix make it into a release? | How to file a pick request?

@riteshshukla04
Copy link
Contributor Author

riteshshukla04 commented Apr 30, 2025

Thanks for merging @cortinico @mateoguzmana . If you have more files to migrate, please let me know . I enjoy contributing here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants