Use static values for undefined and auto lengths #47305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65207753 |
Summary: X-link: facebook/yoga#1734 X-link: facebook/litho#1030 Profiling in a test app with many undefined lengths shows this saves roughly 33% of time spent in Yoga. ## Changelog [General][Fixed] Reduce amount of time spent in Yoga by reusing statically defined values in StyleLength::getLength() Reviewed By: yungsters, mdvacca Differential Revision: D65207753
rozele
added a commit
to rozele/yoga
that referenced
this pull request
Oct 30, 2024
Summary: X-link: facebook/react-native#47305 X-link: facebook/litho#1030 Profiling in a test app with many undefined lengths shows this saves roughly 33% of time spent in Yoga. ## Changelog [General][Fixed] Reduce amount of time spent in Yoga by reusing statically defined values in StyleLength::getLength() Reviewed By: yungsters, mdvacca Differential Revision: D65207753
rozele
force-pushed
the
export-D65207753
branch
from
2b9ef68 to
a2138b7
Compare
rozele
added a commit
to rozele/litho
that referenced
this pull request
Oct 30, 2024
Summary: X-link: facebook/react-native#47305 X-link: facebook/yoga#1734 Profiling in a test app with many undefined lengths shows this saves roughly 33% of time spent in Yoga. ## Changelog [General][Fixed] Reduce amount of time spent in Yoga by reusing statically defined values in StyleLength::getLength() Reviewed By: yungsters, mdvacca Differential Revision: D65207753
|
This pull request was exported from Phabricator. Differential Revision: D65207753 |
|
Closed internally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/yoga#1734
X-link: facebook/litho#1030
Profiling in a test app with many undefined lengths shows this saves roughly 33% of time spent in Yoga.
Changelog
[General][Fixed] Reduce amount of time spent in Yoga by reusing statically defined values in StyleLength::getLength()
Reviewed By: yungsters
Differential Revision: D65207753