[lexical-table] Bug Fix: table cell background copy paste not working

[jvithlani]

Description

While copy pasting a table cell with background color, the background color doesn't carry forward with the table details

Test plan

Before

Screen.Recording.2025-02-22.at.2.47.52.PM.mov

After

Screen.Recording.2025-02-22.at.2.48.56.PM.mov

Insert relevant screenshots/recordings/automated-tests

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 22, 2025 6:50am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 22, 2025 6:50am

[facebook-github-bot]

Hi @jvithlani!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[etrepum]

You'll need to sign the CLA before we can run the tests and possibly merge this PR

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[etrepum]

It doesn't look like this change passes the existing e2e test suite (possibly because the tests should change to accommodate this new behavior), and there are no new tests that verify that it works now. Further work will have to be done here before it can be merged.

Test suite failures

[ivailop7]

@jvithlani are you planning on finishing this one?

[jvithlani]

Hey @ivailop7, yes ill wrap this up, was a little caught up. Will finish it this week

[jvithlani]

@ivailop7 @etrepum i see unrelated tests failing, which are working fine on local, can you guys help me fix it

[etrepum]

Doesn’t look unrelated? This is the failing test

[chromium] › packages/lexical-playground/tests/e2e/CopyAndPaste/html/TablesHTMLCopyAndPaste.spec.mjs:351:3 › HTML Tables CopyAndPaste › Copy + paste - Merge Grids

[jvithlani]

@etrepum i need some help here, i had left this as it looked like a longer debug.
I went through the flow, as im trying to mutate the node by setting the background color, a new dom element is being created and replaced, which doesnt have the TableCellSelected class. This was working fine till now as no properties are being imported on pasting.

My concern here is although the table is still selected in the lexical's selection, why didnt the tableObserver update the classes of the new DOM created in the tableCell, i also tried adding a
$updateDOMForSelection(editor, tableObserver.getTable(), selection);
but this also doesnt help, any help would be much appreciated

[jvithlani]

@etrepum tiny bump here

[ivailop7]

@jvithlani the tests are still failing.

Edit: Nevermind, I see Bob has commented on this already.

[jvithlani]

@ivailop7 waiting for Bob's reply

[etrepum]

I probably won’t have time to look into this for a few days, this level of question is basically asking me to fix it. It’s a long holiday weekend in the US.