Skip to content

fix: check Node.js version early (#5430) #17108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aarshpatel12
Copy link

This PR adds an early check to ensure that users are running a compatible version of Node.js when using create-react-app. If the Node version is below the required minimum, a clear error message is shown and the process exits.

@facebook-github-bot
Copy link

Hi @Aarshpatel12!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Aarshpatel12
Copy link
Author

Hi maintainers! 👋
I've signed the Contributor License Agreement (CLA) and completed the required changes for issue #5430.
Looking forward to your review. 🚀

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Aarshpatel12
Copy link
Author

Hi maintainers 👋
All checks have passed and the CLA is signed ✅. This PR adds an early Node.js version check (Fixes: #5430). Could someone please approve the workflow to proceed? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants