[APPAI-1733] Use head ref to create PR across repos #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajkumar
reviewed
Feb 15, 2021
| @@ -57,8 +57,8 @@ def update_content(self, branch_name: str, file_path: str, update_message: str, | |||
| current_sha, branch=f'refs/heads/{branch_name}') | |||
| return update['commit'].sha | |||
|
|
|||
| def create_pr(self, branch_name: str, title: str, body: str) -> str: | |||
There was a problem hiding this comment.
Can you do the same for update_content as well? It will be uniform.
arajkumar
reviewed
Feb 15, 2021
| """Raise the PR to merge changes from branch to master.""" | ||
| pr = self._repo.create_pull(title=title, body=body, head=f'refs/heads/{branch_name}', | ||
| pr = self._repo.create_pull(title=title, body=body, head=head_ref, | ||
| base=f'refs/heads/{self._master_ref}') |
There was a problem hiding this comment.
Even you can consider taking a head ref for base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create PR function enhanced to take head reference to create PR across repos.
Fixes # (issue)
This feature is required by Jira ticket https://issues.redhat.com/browse/APPAI-1733
Type of change
Please delete options that are not relevant.