Skip to content

Conversation

@MangelMaxime
Copy link
Contributor

  1. Make build.sh executable
  2. Add a name to package.json otherwise the package-lock.json gets changes based on the folder name
  3. Add support for optional message in the expect method

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for an optional message parameter to the expect API in the Vitest bindings, along with project configuration improvements. The optional message parameter allows developers to provide custom error messages when assertions fail, enhancing test debugging capabilities.

Key changes:

  • Enhanced the expect method signature to accept an optional message parameter
  • Added a test case demonstrating the new optional message functionality
  • Fixed package.json configuration by adding a stable package name

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
src/Vitest/Library.fs Added optional msg parameter to the expect method signature
tests/Vitest/Program.test.fs Added test case demonstrating usage of the optional message parameter
package.json Added package name to stabilize package-lock.json generation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MangelMaxime MangelMaxime force-pushed the add_optional_msg_in_expect branch from f169dbf to db73990 Compare October 20, 2025 19:57
Copy link
Contributor

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR please update src/Vitest/CHANGELOG.md and add your changes to UNRELEASED or tick up the rc by one number if you want it to be released directly 🙂

@Freymaurer Freymaurer merged commit 58b9f4f into feliz_v3.0 Oct 20, 2025
2 checks passed
@MangelMaxime MangelMaxime deleted the add_optional_msg_in_expect branch October 21, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants