Skip to content

Conversation

@laurentpayot
Copy link

Added the missing menu element to Html.fs so it behaves the same as the ul element, as it is a semantic alternative: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu

Added the missing `menu` element to Html.fs so it behaves the same as  the `ul` element, as it is a *semantic* alternative: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu
@laurentpayot
Copy link
Author

CI issue? 🤔

@Freymaurer
Copy link
Contributor

Hello @laurentpayot i am currently working on a project restructure, are you willing to rebase the PR/create a new PR when it is ready, or should i just add your code?

@laurentpayot
Copy link
Author

laurentpayot commented May 2, 2025

Hello @Freymaurer. I did not clone the project locally and git push, but simply did it online with GitHub automagically handling it, and I don’t know if rebasing is easy with GitHub.
By the way I was about to create another PR for missing popover API HTML attributes.
So what do you think is the best?

@Freymaurer
Copy link
Contributor

Easiest is propably to give it some time. When i ping you, you can open a new pr based on the then state. If that is fine with you

@laurentpayot
Copy link
Author

Easiest is propably to give it some time. When i ping you, you can open a new pr based on the then state. If that is fine with you

Sure, no problem. Do you want me to close this PR for now?

@Freymaurer
Copy link
Contributor

@laurentpayot let it stay open, so i can remember 😄

@laurentpayot
Copy link
Author

@laurentpayot let it stay open, so i can remember 😄

Sure, so I can remember too 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants