feat: create cache method for caching schema output by input #1170
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| private duration: number | undefined; | ||
| private cache = new Map<TKey, _CacheEntry<TValue>>(); | ||
| constructor(options?: _CacheOptions) { | ||
| this.maxSize = options?.maxSize ?? 1; |
There was a problem hiding this comment.
Should maxSize be Infinity or a number like 100 or 1,000 if not set? Infinity is probably a bad default because attackers could abuse it.
There was a problem hiding this comment.
a default of 1 is pretty common - for example reselect and proxy-memoize
There was a problem hiding this comment.
But doesn't this mean that cache is pretty useless if you don't specify maxSize?
There was a problem hiding this comment.
Not really. If 2nd run is done with same value, it wouldn’t re-evaluate, just use cached result
There was a problem hiding this comment.
I am open to discussing this, but right now I would probably choose a default that makes the most sense, so that people only need to define a custom value for special needs.
There was a problem hiding this comment.
for memoize libraries i think a lot of people leave it as 1, but i guess it could be argued a schema is more likely to be called with different values
commit: |
… with access order
fixes #923