Skip to content

Checkbox based CI workflow #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 26, 2025

Conversation

mwestphal
Copy link
Member

@mwestphal mwestphal commented Apr 24, 2025

Describe your changes

  • Add a PULL_REQUEST_TEMPLATE.md
  • Add a linux_fast CI
  • Add a checkbox checking logic to detect which CI to run

Note: If someone add a checked checkbox and put "Full CI" next to it anywhere in the PR description , CI will run even if not intended. That seems fine to me.

Issue ticket number and link if any

Related to: #194

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the default versions, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • Style checks
  • Fast CI
  • Coverage cached CI
  • Analysis cached CI
  • WASM CI
  • Android CI
  • macOS Intel cached CI
  • macOS ARM cached CI
  • Windows cached CI
  • Linux cached CI
  • Other cached CI

@mwestphal mwestphal requested a review from Meakk April 24, 2025 07:04
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (acc053c) to head (a7800ff).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2177      +/-   ##
==========================================
+ Coverage   95.86%   95.90%   +0.03%     
==========================================
  Files         127      127              
  Lines       11060    11090      +30     
==========================================
+ Hits        10603    10636      +33     
+ Misses        457      454       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's see if it works well in practice and adjust it if needed.

@mwestphal mwestphal merged commit ab54472 into f3d-app:master Apr 26, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants