Skip to content

vtkF3DMetaImporter: Fix coloring for skinning, morphing, and such #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 26, 2025

Conversation

mwestphal
Copy link
Member

@mwestphal mwestphal commented Apr 21, 2025

  • Proper Coloring/PointSprits actor creation by shallow copying Prop3D
  • Add animation support for coloring and point sprites with a special case for generic importer
  • Add test covering coloring ( and coloring animation ) for user transform, morphing, skinning and input change
  • Add test covering point sprits (and point sprites animation) for user transform and input change
  • Add a test for generic importer animation and point sprites

Fix: #2000

@mwestphal mwestphal changed the title vtkF3DMetaImporter: Fix coloring for skinning, morphing, transform, a… vtkF3DMetaImporter: Fix coloring for skinning, morphing, and such Apr 24, 2025
@mwestphal mwestphal marked this pull request as ready for review April 25, 2025 07:42
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (bbb0a63) to head (7c16caf).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2172      +/-   ##
==========================================
+ Coverage   95.86%   95.88%   +0.01%     
==========================================
  Files         127      127              
  Lines       11060    11104      +44     
==========================================
+ Hits        10603    10647      +44     
  Misses        457      457              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal requested a review from Meakk April 25, 2025 11:55
@mwestphal
Copy link
Member Author

@exbluesbreaker @Meakk please review

Copy link
Contributor

@exbluesbreaker exbluesbreaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I also checked already how it works and behavior is as expected

@mwestphal mwestphal merged commit 9994d18 into f3d-app:master Apr 26, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File with multiple actors only show first actor when coloring
3 participants