forked from jsverse/transloco
-
Notifications
You must be signed in to change notification settings - Fork 1
Update intlmessageformat transpiler #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
plaskowski-bqs
wants to merge
263
commits into
f-aubert:transloco-intlmessageformat
Choose a base branch
from
plaskowski-bqs:transloco-intlmessageformat
base: transloco-intlmessageformat
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update intlmessageformat transpiler #1
plaskowski-bqs
wants to merge
263
commits into
f-aubert:transloco-intlmessageformat
from
plaskowski-bqs:transloco-intlmessageformat
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: 🤖 upgrade to angular v16 BREAKING CHANGE: 🧨 Angular 16
BREAKING CHANGE: 🧨 Min node version is 16
BREAKING CHANGE: 🧨 min node version is 16
BREAKING CHANGE: 🧨 min node version is 16
BREAKING CHANGE: 🧨 min node version is 16
BREAKING CHANGE: 🧨 Minimum Angular version is now 16 ✅ Closes: jsverse#646
* origin/master: fix(transloco-scoped-libs): 🐛 remove unwanted peerDependencies (jsverse#668)
BREAKING CHANGE: 🧨 Rename injection tokens
* ci: 🎡 update ci workflow
- project: transloco 7.5.0
- project: transloco-persist-lang 7.0.2
* origin/master: docs(transloco): add link to commit in changelog (jsverse#800)
- project: transloco 7.5.1
…sverse#821) In this commit, we tree-shake injection token names in production by inlining the `ngDevMode` condition. This is the same approach that Angular uses. See, for instance: https://tinyurl.com/4y9dxzsp (long GitHub URL). `ngDevMode` cannot be extracted into a separate shared variable, as this would result in a separate runtime variable. The condition must always be inlined for the minifier to work correctly.
* ci: added pkg.pr.new * ci: added restriction to prevent multiple prereleases Co-authored-by: Shahar Kazaz <shahar.kazaz@gmail.com> * ci: fix libs folder Co-authored-by: Shahar Kazaz <shahar.kazaz@gmail.com> --------- Co-authored-by: Shahar Kazaz <shahar.kazaz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an alternative messageformat transpiler based on formatjs/intlmessageformat based on jsverse#649
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Transloco MessageFormatTranspiler may lead to CSP Problems due to usage (in messageformat.js) of the eval function.
Issue Number: jsverse#364
What is the new behavior?
Provide an alternative IntlMessaeFormatTranspiler based on formatjs/intl(messageformat)
Does this PR introduce a breaking change?
Other information