Skip to content

Update intlmessageformat transpiler #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 263 commits into
base: transloco-intlmessageformat
Choose a base branch
from

Conversation

plaskowski-bqs
Copy link

Adding an alternative messageformat transpiler based on formatjs/intlmessageformat based on jsverse#649

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Transloco MessageFormatTranspiler may lead to CSP Problems due to usage (in messageformat.js) of the eval function.

Issue Number: jsverse#364

What is the new behavior?

Provide an alternative IntlMessaeFormatTranspiler based on formatjs/intl(messageformat)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

shaharkazaz and others added 30 commits June 10, 2023 17:22
chore: 🤖 upgrade to angular v16

BREAKING CHANGE: 🧨 Angular 16
BREAKING CHANGE: 🧨 Min node version is 16
BREAKING CHANGE: 🧨 min node version is 16
BREAKING CHANGE: 🧨   min node version is 16
BREAKING CHANGE: 🧨   min node version is 16
BREAKING CHANGE: 🧨 Minimum Angular version is now 16

✅ Closes: jsverse#646
* origin/master:
  fix(transloco-scoped-libs): 🐛 remove unwanted peerDependencies (jsverse#668)
BREAKING CHANGE: 🧨 Rename injection tokens
shaharkazaz and others added 30 commits September 16, 2024 23:45
* ci: 🎡 update ci workflow
- project: transloco 7.5.0
- project: transloco-persist-lang 7.0.2
* origin/master:
  docs(transloco): add link to commit in changelog (jsverse#800)
- project: transloco 7.5.1
…sverse#821)

In this commit, we tree-shake injection token names in production by inlining the `ngDevMode`
condition. This is the same approach that Angular uses.

See, for instance: https://tinyurl.com/4y9dxzsp (long GitHub URL).

`ngDevMode` cannot be extracted into a separate shared variable, as this would result in a
separate runtime variable. The condition must always be inlined for the minifier
to work correctly.
* ci: added pkg.pr.new

* ci: added restriction to prevent multiple prereleases

Co-authored-by: Shahar Kazaz <shahar.kazaz@gmail.com>

* ci: fix libs folder

Co-authored-by: Shahar Kazaz <shahar.kazaz@gmail.com>

---------

Co-authored-by: Shahar Kazaz <shahar.kazaz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.