Skip to content

📝 list languages in table to prevent GH right-aligning list due to RTL language #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

ctcpip
Copy link
Member

@ctcpip ctcpip commented May 23, 2025

note: I did not update this in the translated readmes because they are all in different states/age and most do not list all the languages, so would require additional translation. probably safe to just do a machine translation, but that could be done as a follow-up

@ctcpip ctcpip requested review from LinusU and UlisesGascon May 23, 2025 16:03
@ctcpip
Copy link
Member Author

ctcpip commented May 23, 2025

before/after:

Screenshot 2025-05-23 at 11 04 37 AM

@coveralls

This comment was marked as off-topic.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, while i work on making the READMEs translatable via Crowdin

@ctcpip ctcpip merged commit 061f4cb into expressjs:main May 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants