Skip to content

Sync changes to v2.x #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 39 commits into from
Closed

Sync changes to v2.x #1312

wants to merge 39 commits into from

Conversation

UlisesGascon
Copy link
Member

No description provided.

3imed-jaberi and others added 30 commits August 17, 2019 03:21
add Arabic translation for README ..
update the link for the "Node.js error handling" blog post to the archived version
Improved documentation translation to Spanish
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
Improve the Brazilian Portuguese translation
- PR-URL: #1251
- Fix a issue with pt-br readme
- English link was linking to russian documentation
* ci: replace travis with github action

* docs: replace travis badge by github action badge

* chore: update dependencies and scripts

* ci: add code coverage

* ci: remove unused supertest

* chore: update mkdirp as the version used was deprecated

* ci: remove node 0.8

* chore: comment node v5, v7, v9

* chore: comment node v5, v7, v9

* chore: comment node v5, v7, v9

* chore: remove comments

* test: add exit option to mocha and separate lint command

* ci: include node 5,7 and 9 again

* ci: revert include node 5,7 and 9 again

* ci: remove node v5,7 and 9

* Update package.json

Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>

* Delete package-lock.json

---------

Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -0,0 +1,187 @@
name: ci

Check failure

Code scanning / Scorecard

Token-Permissions High

score is 0: no topLevel permission defined
Remediation tip: Visit https://app.stepsecurity.io/secureworkflow.
Tick the 'Restrict permissions for GITHUB_TOKEN'
Untick other options
NOTE: If you want to resolve multiple issues at once, you can visit https://app.stepsecurity.io/securerepo instead.
Click Remediation section below for further remediation help
node-version: "22.0"

steps:
- uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 3: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help

- name: Install npm module(s) ${{ matrix.npm-i }}
run: npm install --save-dev ${{ matrix.npm-i }}
if: matrix.npm-i != ''

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 3: npmCommand not pinned by hash
Click Remediation section below to solve this issue

- name: Install Node.js dependencies
run: npm install

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 3: npmCommand not pinned by hash
Click Remediation section below to solve this issue
fi

- name: Collect code coverage
uses: coverallsapp/github-action@master

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 3: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
runs-on: ubuntu-latest
steps:
- name: Upload code coverage
uses: coverallsapp/github-action@master

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 3: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a rebase

@UlisesGascon
Copy link
Member Author

this needs a rebase

Yep! I will work in a proper rebase, I will left this draft PR open until is done

@ctcpip
Copy link
Member

ctcpip commented May 21, 2025

merge/rebase is here: #1317

the pure rebased version I did still ended up with conflicts, so I don't think we can avoid the merge commit

@ctcpip ctcpip closed this May 21, 2025
@UlisesGascon UlisesGascon deleted the master branch May 22, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.