Skip to content

[StepSecurity] Apply security best practices #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

step-security-bot
Copy link
Contributor

@step-security-bot step-security-bot commented May 17, 2025

Related expressjs/security-wg#2

Summary

This pull request is created by StepSecurity at the request of @UlisesGascon. Please merge the Pull Request to incorporate the requested changes. Please tag @UlisesGascon on your message if you have any questions related to the PR.
Related expressjs/security-wg#2

Security Fixes

Least Privileged GitHub Actions Token Permissions

The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.

Pinned Dependencies

GitHub Action tags and Docker tags are mutable. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.

Keeping your actions up to date with Dependabot

With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
@UlisesGascon UlisesGascon self-assigned this May 17, 2025
@coveralls
Copy link

coveralls commented May 17, 2025

Coverage Status

coverage: 98.842%. remained the same
when pulling d35318d on step-security-bot:chore/GHA-171534-stepsecurity-remediation
into 6517e9a on expressjs:master.

@UlisesGascon UlisesGascon deleted the branch expressjs:main May 22, 2025 13:47
@UlisesGascon UlisesGascon reopened this May 22, 2025
@UlisesGascon UlisesGascon changed the base branch from master to v2 May 22, 2025 14:14
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon UlisesGascon merged commit f897007 into expressjs:main Jun 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants