Skip to content

Replace Google Font with local variable font #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 28, 2025
Merged

Replace Google Font with local variable font #1910

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
18cf43f
Removed the Google OpenSans with fontsource/open-sans
utkarsh125 May 20, 2025
d0b1886
Placed the fonts inside the project directory itself
utkarsh125 May 23, 2025
aab6301
Fixed the fonts not being read
utkarsh125 May 23, 2025
860e96e
Removed redundant fonts, and also removed css/fonts
utkarsh125 May 24, 2025
fcd87bf
Changed the font-weight (100 to 700) range
utkarsh125 May 24, 2025
5e1a6ed
correct font family name and remove ttf font files
ShubhamOulkar May 25, 2025
53b65da
correcting italic font file name
ShubhamOulkar May 25, 2025
5540a44
Removed ttf fonts and renamed the font fileNames for simplicity
utkarsh125 May 25, 2025
7e66ce9
font imports removed from style.css
utkarsh125 May 28, 2025
b543dd9
Merge branch 'gh-pages' into removal-of-google-fonts
ShubhamOulkar May 28, 2025
3c16d21
fix: path fix and font preload
utkarsh125 May 28, 2025
44d7d33
fix: fixed fonts.css order
utkarsh125 May 28, 2025
0167c97
chore: removed additional whitespaces
utkarsh125 May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion _includes/head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<link rel="stylesheet" href="/css/sintax.css?_={{ site.time | date: '%s' }}">

<link rel="stylesheet" href="/css/font-awesome.min.css">
<link rel="stylesheet" href="//fonts.googleapis.com/css?family=Open+Sans:300,400,600,700&amp;amp;subset=latin,latin-ext">
<link rel="stylesheet" href="/css/langs/{{ page.lang }}.css">

<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Expand Down
2 changes: 2 additions & 0 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import url("../fonts/open-sans/fonts.css");
Copy link
Member

@bjohansebas bjohansebas May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be imported from the head

using @import is considered bad practice.

Copy link
Member

@ShubhamOulkar ShubhamOulkar May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re right. I was initially planning to use the {page.lang}.css file to import fonts, similar to how it's done for the Korean font. However, since the font is shared across multiple languages, it doesn’t make sense to repeat the same @font-face rule in each language-specific CSS file.

I suggest defining @font-face directly in style.css instead. WDYT?

Edit:- It is better to write @font-face rule in ko.css file.

Copy link
Member

@bjohansebas bjohansebas May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d prefer to keep the font imports separate, that file is too large. The location of the file is fine in my opinion, but it should be in the HEAD.
Edit: By the way, @ShubhamOulkar wrap font-face in backticks (` `) so we don’t ping other people unnecessarily—GitHub stuff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be in the HEAD.

Ok, then the only option is to use one more <link>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamOulkar @bjohansebas I've added this in HTML file

    <link 
        rel="preload" 
        href="/fonts/open-sans/OpenSans.woff2" 
        as="font" 
        type="font/woff2" 
        crossorigin 
    />
    <link 
        rel="preload" 
        href="/fonts/open-sans/OpenSans-Italic.woff2" 
        as="font" 
        type="font/woff2" 
        crossorigin 
    />
    <link
        href="/fonts/open-sans/OpenSans.woff"
        as="font"
        type="font/woff"
        crossorigin
    />
    <link
        href="/fonts/open-sans/woff/OpenSans-Italic.woff"
        as="font"
        type="font/woff"
        crossorigin
    />

We can preload woff2 since the file since is smaller, and use woff as fallback. apart from that I have also removed @imports. I've kept the fonts separate from the main style.css (so only the import line is removed).


* {
box-sizing: border-box;
-webkit-tap-highlight-color: transparent;
Expand Down
19 changes: 19 additions & 0 deletions fonts/open-sans/fonts.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
@font-face {
font-family: "Open Sans";
font-style: normal;
font-weight: 100 700;
font-display: swap;
src: local("Open Sans"),
url("./woff2/OpenSans.woff2") format("woff2"),
url("./woff/OpenSans.woff") format("woff"),
}

@font-face {
font-family: "Open Sans";
font-style: italic;
font-weight: 100 700;
font-display: swap;
src: local("Open Sans"),
url("./woff2/OpenSans-Italic.woff2") format("woff2"),
url("./woff/OpenSans-Italic.woff") format("woff"),
}
Binary file added fonts/open-sans/ttf/OpenSans-Italic-VariableFont_wdth,wght.ttf
View file
Open in desktop
Binary file not shown.
Binary file added fonts/open-sans/ttf/OpenSans-VariableFont_wdth,wght.ttf
View file
Open in desktop
Binary file not shown.
Binary file added fonts/open-sans/woff/OpenSans-Italic-VariableFont_wdth,wght.woff
View file
Open in desktop
Binary file not shown.
Binary file added fonts/open-sans/woff/OpenSans-VariableFont_wdth,wght.woff
View file
Open in desktop
Binary file not shown.
Binary file added fonts/open-sans/woff2/OpenSans-Italic-VariableFont_wdth,wght.woff2
View file
Open in desktop
Binary file not shown.
Binary file added fonts/open-sans/woff2/OpenSans-VariableFont_wdth,wght.woff2
View file
Open in desktop
Binary file not shown.
Loading