Skip to content

ci: delete translation workflow #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

bjohansebas
Copy link
Member

Unlike what #1642 does, this workflow is removed due to permission issues.

Maybe what we want to do is create a bot on GitHub that adds these labels like Node.js does. Or maybe this won't be necessary either if we manage to automate the translations.

ref:

@bjohansebas bjohansebas requested review from UlisesGascon and a team December 9, 2024 16:11
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 9f98ada
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/675716a2d42e7d0009aecca4
😎 Deploy Preview https://deploy-preview-1710--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following with the last discussions around this, seems like this pipeline won't be necessary as we move to machine translations 👍

@UlisesGascon
Copy link
Member

I will land it as this pipeline is broken anyway (with the permissions issue). This will reduce the noise in new and existing PR(s) cc: @expressjs/docs-captains

@UlisesGascon UlisesGascon merged commit 2275070 into expressjs:gh-pages Dec 20, 2024
7 checks passed
@bjohansebas bjohansebas deleted the remove-workflow branch January 6, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants