Skip to content

Update path-to-regexp #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update path-to-regexp #3409

wants to merge 1 commit into from

Conversation

Kurounin
Copy link

@Kurounin Kurounin commented Sep 4, 2017

Update path-to-regexp npm module

@Kurounin
Update path-to-regexp
8c878a5 
Update path-to-regexp npm module
@blakeembrey
Copy link
Member

path-to-regexp 1 and 2 are incompatible with 0.1.x used in Express.js, so this would need to be part of a major version bump. Take a look at the 5.0 PR (#2237) and previous update PRs (#2530, #2173).

@Kurounin
Copy link
Author

Kurounin commented Sep 5, 2017

Didn't realise it. I noticed afterwards that the tests failed. I'll close this PR.

@Kurounin Kurounin closed this Sep 5, 2017
This was referenced Jan 17, 2019
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kurounin @blakeembrey