feat(detox): Add optional Test Butler setup #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmiles
force-pushed
the
feat/detox-test-butler
branch
from
9476995 to
b06a577
Compare
mhmiles
changed the title
mhmiles
force-pushed
the
feat/detox-test-butler
branch
from
b06a577 to
f4d79ed
Compare
EvanBacon
requested changes
Jan 3, 2023
Collaborator
EvanBacon
left a comment
EvanBacon
left a comment
There was a problem hiding this comment.
Can you add tests for this feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I wanted to enable Test Butler with Detox on Android. This requires modification of some of the same files/lines as
@config-plugins/detoxso I was not able to develop the change as a separate package.How
Added new option to @config-plugins/detox:
includeTestButlerSetting this option to
truewill include the test library inapp/build.gradleand make the necessary modifications to the test runner to engage Test Butler.Test Plan
I have tested this locally by building and using it within my own app. Testing requires utilizing this change with
includeTestButlerset totrueand downloading the Test Butler APK:and installing it with Detox.