Skip to content

Refactor view methods in file handlers to accept width and height parameters #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YidingQiu
Copy link

Related to Issue #1779 .
Hi, I'm new here, I want to start with something simple starting to contribute to this project.
This update introduces optional width and height parameters to the view_() functions, allowing users to specify the size of the display when viewing images or files. This change enhances the flexibility of the view() function, enabling better control over how the content is rendered.
Now, users can specify the desired display size with the following syntax:

from edsl import FileStore
fs = FileStore(path="/Users/johnhorton/Downloads/things.png")
fs.view(width=100, height=100)  # The width and height are now customizable
fs.view(100)  # Width first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant