Remove not-working iterations check #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iteration 0 is allowed. This check was not working due to strict-compare between string and int always returning false
styxit
added
the
enhancement
trizz
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove not-working iterations check. Iteration 0 is valid. This check was not working due to strict-compare between string and int always returning false
Even when providing 0 as iteration it was comparing
'0' === 0. Because this is a strict-compare, it always returns false.Motivation and context
It removes code that looks like it should prevent using 0 as iteration while in reality this was not the case.
How has this been tested?
All tests ran and pass. Some testcases use 0 as iteration and they still are passing.