Skip to content

Conversation

@tvedeane
Copy link
Contributor

This PR tries to solve issues discussed briefly here: https://forum.exercism.org/t/adds-database-class-to-objectrelationalmapping-cs/16314

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Apr 27, 2025
@ErikSchierboom
Copy link
Member

I appreciate that this is confusing. The proper fix is to move the Database class out of the tests file (https://github.com/exercism/csharp/blob/main/exercises/concept/object-relational-mapping/ObjectRelationalMappingTests.cs#L83) and into it's own, separate file. It then needs to be added to the files.editor key in the .meta/config.json file (https://github.com/exercism/csharp/blob/main/exercises/concept/object-relational-mapping/.meta/config.json).

@tvedeane
Copy link
Contributor Author

Thanks for explaining @ErikSchierboom . I followed your suggestions, but I wasn't sure about the details. So this should be definitely properly reviewed (and ideally tested).

tvedeane and others added 2 commits April 29, 2025 20:26
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@ErikSchierboom ErikSchierboom merged commit 17be731 into exercism:main Apr 29, 2025
2 of 3 checks passed
@ErikSchierboom
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants