Skip to content

Jupyterlite button - patched, merged version of #655 #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025

Conversation

matthew-brett
Copy link
Collaborator

@matthew-brett matthew-brett commented Jun 5, 2025

This is very slight adaptation of #655 - but rebased on current origin/master, with conflicts resolved.

I wonder whether you'd consider merging this as-is - I am using it already with benefit, and it's painful not to be able to use JupyterLite without having to resort to installing from my own branch.

In case anyone is interested, here's an example gh-pages output for a repo where we're using it: https://odsti.github.io/cfd-textbook/using_jupyter.html .

I hacked this by putting a Makefile target in to do the JupyterLite build - odsti/cfd-textbook@0c5d91c - and doing a minimal patch to #655 - matthew-brett@1892593 .

@choldgraf
Copy link
Member

choldgraf commented Jun 5, 2025

IMO I think I'm fine merging as-is, if you add some lightweight documentation :-). It can be as simple as "JupyterLite support exists, here's the config to use it".

@matthew-brett
Copy link
Collaborator Author

Thanks - I will add documentation. I'm afraid I don't understand what's going on with the CI failure : https://github.com/executablebooks/sphinx-book-theme/actions/runs/15472248434/job/43559352670#logs - but presumably that has nothing to do with the current PR.

@choldgraf
Copy link
Member

don't sweat it - your request was "as-is" and I meant it when I said that documentation was the only thing I think is needed haha

@matthew-brett
Copy link
Collaborator Author

@choldgraf - is the added documentation OK?

@choldgraf choldgraf merged commit 56874cb into executablebooks:master Jun 5, 2025
17 of 19 checks passed
@matthew-brett
Copy link
Collaborator Author

Thanks much!

@matthew-brett
Copy link
Collaborator Author

When are you planning to do the next release?

@choldgraf
Copy link
Member

choldgraf commented Jun 6, 2025

I've added you as a maintainer to the package and opened an issue with a link to instructions for releases that I think should work. Would you be willing to give that a shot?

@matthew-brett
Copy link
Collaborator Author

I'll give it a shot ... Next week though.

@choldgraf
Copy link
Member

no rush at all - I just don't want you to be blocked on me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants