Improvements to psick::admin #91
pr.yml
on: pull_request
  
    
      Syntax validation
    
          
              27s
          
      
    
      Unit tests
    
          
              12m 35s
          
      
    
      Unit tests Legacy Puppet
    
          
              19s
          
      Annotations
15 errors and 20 warnings
          | 
                      
                          Unit tests Legacy Puppet
                        
                      
                       Process completed with exit code 1. | 
| 
                      
                          Syntax validation
                        
                      
                       Process completed with exit code 1. | 
| 
                      
                          Syntax validation: 
                        manifests/bolt/node.pp#L80
                      
                       there should be a single space or single newline after an opening brace (check: manifest_whitespace_opening_brace_after) | 
| 
                      
                          Syntax validation: 
                        manifests/bolt/master.pp#L94
                      
                       two-space soft tabs not used (check: 2sp_soft_tabs) | 
| 
                      
                          Unit tests
                        
                      
                       Process completed with exit code 1. | 
| 
                      
                          Unit tests: 
                        spec/classes/puppet/foss_server_metrics_spec.rb#L17
                      
                       psick::puppet::foss_server_metrics on ubuntu-18.04-x86_64 is expected to compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile.with_all_deps }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'has_key'. (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config/helper.pp, line: 10, column: 6) (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config.pp, line: 2) on node d3cabb28af30.q1rngnngb1ye5ngoly4epqhwef.cx.internal.cloudapp.net | 
| 
                      
                          Unit tests: 
                        spec/classes/puppet/foss_server_metrics_spec.rb#L17
                      
                       psick::puppet::foss_server_metrics on debian-12-x86_64 is expected to compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile.with_all_deps }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'has_key'. (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config/helper.pp, line: 10, column: 6) (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config.pp, line: 2) on node d3cabb28af30.q1rngnngb1ye5ngoly4epqhwef.cx.internal.cloudapp.net | 
| 
                      
                          Unit tests: 
                        spec/classes/puppet/foss_server_metrics_spec.rb#L17
                      
                       psick::puppet::foss_server_metrics on debian-11-x86_64 is expected to compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile.with_all_deps }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'has_key'. (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config/helper.pp, line: 10, column: 6) (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config.pp, line: 2) on node d3cabb28af30.q1rngnngb1ye5ngoly4epqhwef.cx.internal.cloudapp.net | 
| 
                      
                          Unit tests: 
                        spec/classes/puppet/foss_server_metrics_spec.rb#L17
                      
                       psick::puppet::foss_server_metrics on sles-12-x86_64 is expected to compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile.with_all_deps }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'has_key'. (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config/helper.pp, line: 10, column: 6) (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config.pp, line: 2) on node d3cabb28af30.q1rngnngb1ye5ngoly4epqhwef.cx.internal.cloudapp.net | 
| 
                      
                          Unit tests: 
                        spec/classes/puppet/foss_server_metrics_spec.rb#L17
                      
                       psick::puppet::foss_server_metrics on oraclelinux-9-x86_64 is expected to compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile.with_all_deps }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'has_key'. (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config/helper.pp, line: 10, column: 6) (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config.pp, line: 2) on node d3cabb28af30.q1rngnngb1ye5ngoly4epqhwef.cx.internal.cloudapp.net | 
| 
                      
                          Unit tests: 
                        spec/classes/puppet/foss_server_metrics_spec.rb#L17
                      
                       psick::puppet::foss_server_metrics on oraclelinux-8-x86_64 is expected to compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile.with_all_deps }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'has_key'. (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config/helper.pp, line: 10, column: 6) (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config.pp, line: 2) on node d3cabb28af30.q1rngnngb1ye5ngoly4epqhwef.cx.internal.cloudapp.net | 
| 
                      
                          Unit tests: 
                        spec/classes/puppet/foss_server_metrics_spec.rb#L17
                      
                       psick::puppet::foss_server_metrics on oraclelinux-7-x86_64 is expected to compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile.with_all_deps }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'has_key'. (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config/helper.pp, line: 10, column: 6) (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config.pp, line: 2) on node d3cabb28af30.q1rngnngb1ye5ngoly4epqhwef.cx.internal.cloudapp.net | 
| 
                      
                          Unit tests: 
                        spec/classes/puppet/foss_server_metrics_spec.rb#L17
                      
                       psick::puppet::foss_server_metrics on centos-9-x86_64 is expected to compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile.with_all_deps }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'has_key'. (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config/helper.pp, line: 10, column: 6) (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config.pp, line: 2) on node d3cabb28af30.q1rngnngb1ye5ngoly4epqhwef.cx.internal.cloudapp.net | 
| 
                      
                          Unit tests: 
                        spec/classes/puppet/foss_server_metrics_spec.rb#L17
                      
                       psick::puppet::foss_server_metrics on redhat-9-x86_64 is expected to compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile.with_all_deps }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'has_key'. (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config/helper.pp, line: 10, column: 6) (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config.pp, line: 2) on node d3cabb28af30.q1rngnngb1ye5ngoly4epqhwef.cx.internal.cloudapp.net | 
| 
                      
                          Unit tests: 
                        spec/classes/puppet/foss_server_metrics_spec.rb#L17
                      
                       psick::puppet::foss_server_metrics on redhat-8-x86_64 is expected to compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile.with_all_deps }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown function: 'has_key'. (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config/helper.pp, line: 10, column: 6) (file: /__w/puppet-psick/puppet-psick/spec/fixtures/modules/puppetserver/manifests/config.pp, line: 2) on node d3cabb28af30.q1rngnngb1ye5ngoly4epqhwef.cx.internal.cloudapp.net | 
| 
                      
                          Syntax validation: 
                        manifests/puppet/postrun.pp#L39
                      
                       there should be a single space before '=>' on line 39, column 14 (check: space_before_arrow) | 
| 
                      
                          Syntax validation: 
                        manifests/puppet/ci.pp#L60
                      
                       there should be a single space before '=>' on line 60, column 15 (check: space_before_arrow) | 
| 
                      
                          Syntax validation: 
                        manifests/puppet/autosign.pp#L28
                      
                       there should be a single space before '=>' on line 28, column 17 (check: space_before_arrow) | 
| 
                      
                          Syntax validation: 
                        manifests/puppet.pp#L54
                      
                       there should be a single space before '=>' on line 54, column 13 (check: space_before_arrow) | 
| 
                      
                          Syntax validation: 
                        manifests/nodejs.pp#L90
                      
                       there should be a single space before '=>' on line 90, column 8 (check: space_before_arrow) | 
| 
                      
                          Syntax validation: 
                        manifests/hosts/resource.pp#L23
                      
                       there should be a single space before '=>' on line 23, column 10 (check: space_before_arrow) | 
| 
                      
                          Syntax validation: 
                        manifests/git/clone.pp#L86
                      
                       there should be a single space before '=>' on line 86, column 13 (check: space_before_arrow) | 
| 
                      
                          Syntax validation: 
                        manifests/bolt/master.pp#L94
                      
                       indent should be 4 chars and is 7 (check: strict_indent) | 
| 
                      
                          Syntax validation: 
                        manifests/bolt/master.pp#L64
                      
                       there should be a single space before '=>' on line 64, column 15 (check: space_before_arrow) | 
| 
                      
                          Syntax validation: 
                        manifests/aws/puppet.pp#L18
                      
                       there should be a single space before '=>' on line 18, column 13 (check: space_before_arrow) | 
| 
                      
                          Unit tests: 
                        spec/classes/bolt/master_spec.rb#L7
                      
                       psick::bolt::master on ubuntu-18.04-x86_64
Skipped: No reason given | 
| 
                      
                          Unit tests: 
                        spec/classes/bolt/master_spec.rb#L7
                      
                       psick::bolt::master on debian-12-x86_64
Skipped: No reason given | 
| 
                      
                          Unit tests: 
                        spec/classes/bolt/master_spec.rb#L7
                      
                       psick::bolt::master on debian-11-x86_64
Skipped: No reason given | 
| 
                      
                          Unit tests: 
                        spec/classes/bolt/master_spec.rb#L7
                      
                       psick::bolt::master on sles-12-x86_64
Skipped: No reason given | 
| 
                      
                          Unit tests: 
                        spec/classes/bolt/master_spec.rb#L7
                      
                       psick::bolt::master on oraclelinux-9-x86_64
Skipped: No reason given | 
| 
                      
                          Unit tests: 
                        spec/classes/bolt/master_spec.rb#L7
                      
                       psick::bolt::master on oraclelinux-8-x86_64
Skipped: No reason given | 
| 
                      
                          Unit tests: 
                        spec/classes/bolt/master_spec.rb#L7
                      
                       psick::bolt::master on oraclelinux-7-x86_64
Skipped: No reason given | 
| 
                      
                          Unit tests: 
                        spec/classes/bolt/master_spec.rb#L7
                      
                       psick::bolt::master on centos-9-x86_64
Skipped: No reason given | 
| 
                      
                          Unit tests: 
                        spec/classes/bolt/master_spec.rb#L7
                      
                       psick::bolt::master on redhat-9-x86_64
Skipped: No reason given | 
| 
                      
                          Unit tests: 
                        spec/classes/bolt/master_spec.rb#L7
                      
                       psick::bolt::master on redhat-8-x86_64
Skipped: No reason given |