Skip to content

Fix single click on cells #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix single click on cells #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25fc925
Make GestureDetector dispatch single click events
Nov 5, 2018
61e8da0
Remove not needed call to GestureDetector onTouchEvent
Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/main/java/com/evrencoskun/tableview/listener/itemclick/AbstractItemClickListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public boolean onSingleTapConfirmed(MotionEvent e) {
@Override
public boolean onDown(MotionEvent e) {
start = e;
return false;
return true;
}

@Override
Expand Down
3 changes: 2 additions & 1 deletion .../java/com/evrencoskun/tableview/listener/itemclick/CellRecyclerViewItemClickListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) {
// Get interacted view from x,y coordinate.
View childView = view.findChildViewUnder(e.getX(), e.getY());

if (childView != null && mGestureDetector.onTouchEvent(e)) {
if (childView != null) {
// Find the view holder
AbstractViewHolder holder = (AbstractViewHolder) mRecyclerView.getChildViewHolder
(childView);
Expand All @@ -72,6 +72,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) {
return false;
}

@Override
protected void longPressAction(MotionEvent e) {
// Consume the action for the time when either the cell row recyclerView or
// the cell recyclerView is scrolling.
Expand Down
3 changes: 2 additions & 1 deletion ...m/evrencoskun/tableview/listener/itemclick/ColumnHeaderRecyclerViewItemClickListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) {
// Get interacted view from x,y coordinate.
View childView = view.findChildViewUnder(e.getX(), e.getY());

if (childView != null && mGestureDetector.onTouchEvent(e)) {
if (childView != null) {
// Find the view holder
AbstractViewHolder holder = (AbstractViewHolder) mRecyclerView.getChildViewHolder
(childView);
Expand All @@ -64,6 +64,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) {
return false;
}

@Override
protected void longPressAction(MotionEvent e) {
// Consume the action for the time when the recyclerView is scrolling.
if (mRecyclerView.getScrollState() != RecyclerView.SCROLL_STATE_IDLE) {
Expand Down
3 changes: 2 additions & 1 deletion .../com/evrencoskun/tableview/listener/itemclick/RowHeaderRecyclerViewItemClickListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) {
// Get interacted view from x,y coordinate.
View childView = view.findChildViewUnder(e.getX(), e.getY());

if (childView != null && mGestureDetector.onTouchEvent(e)) {
if (childView != null) {
// Find the view holder
AbstractViewHolder holder = (AbstractViewHolder) mRecyclerView.getChildViewHolder
(childView);
Expand All @@ -62,6 +62,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) {
return false;
}

@Override
protected void longPressAction(MotionEvent e) {
// Consume the action for the time when the recyclerView is scrolling.
if (mRecyclerView.getScrollState() != RecyclerView.SCROLL_STATE_IDLE) {
Expand Down