forked from scipy/scipy
-
Notifications
You must be signed in to change notification settings - Fork 0
Rebase ci blas #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ev-br
wants to merge
22
commits into
main
Choose a base branch
from
rebase_ci_blas
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rebase ci blas #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted largely from NumPy's `linux_blas.yml`
ci fix Avoid pytest-cov, and install python311 on OpenSUSE CI: enable Debian libblas/liblapack job CI: add Fedora jobs for OpenBLAS and FlexiBLAS OpenBLAS is detected without pkg-config, because Fedora does not ship an openblas.pc file. FlexiBLAS is detected through pkg-config. CI: add job using BLIS CI: add MKL job CI: add Accelerate (NEWLAPACK LP64) job ENH: enable new macOS Accelerate BLAS/LAPACK support BUG: fix issue with picking up use-g77-abi flag
This was left out initially when adding support for building with Meson. The numpy.distutils based build supported ILP64 builds with OpenBLAS and its `64_` symbol suffix scheme. We now add this back and make it more generic, so that it also supports the `_64` scheme of MKL as well as the `$NEWLAPACK_ILP64` scheme from Accelerate.
DEBUG: enable macos job BUG: ensure F77 ABI wrappers deal with BLAS symbol suffix correctly This avoids build errors that look like: ``` ../scipy/_build_utils/src/wrap_g77_abi_c.c:13:16: error: use of undeclared identifier 'cblas_cdotc_sub' ``` when one uses Accelerate with the `$NEWLAPACK` symbol suffix for example. [ci skip] WIP: ENH: more symbol renaming needed for BLAS symbol suffix support
`qhull.pyx` uses cython_lapack, so linking is done at the build time. NB: and if anything, Qhull might not be 64-bit int ready, so it'll probably need an LP64 LAPACK.
Violations observed on linux with MKL in the ILP64 mode.
It otherwise segfaults. Needs using BLAS_FUNC maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
What does this implement/fix?
Additional information